Bug 127526

Summary: Move RegularExpression into JavaScriptCore for inspector
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, joepeck, sam, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
ggaren: review+
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-01-23 17:15:12 PST
The Inspector will soon need to use RegularExpressions. The current implementation in platform/text only relies on JavaScriptCore/yarr and wtf. Lets move it into JavaScriptCore so the inspector can use it. I'm going to put it in the JSC::Yarr namespace. Let me know if something else might be better.
Attachments
[PATCH] Proposed Fix (51.96 KB, patch)
2014-01-23 17:18 PST, Joseph Pecoraro 		ggaren: review+
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (47.00 KB, patch)
2014-01-23 19:23 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-01-23 17:18:20 PST
Created attachment 222047 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-01-23 17:20:27 PST
Attachment 222047 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/yarr/RegularExpression.cpp:175: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2014-01-23 19:16:46 PST
Comment on attachment 222047 [details] [PATCH] Proposed Fix r=me if you fix the build
Joseph Pecoraro
Comment 4 2014-01-23 19:23:32 PST
Created attachment 222069 [details] [PATCH] Proposed Fix Patch for bots. I had a bunch of future code in the patch. This is the patch rebased onto ToT.
Joseph Pecoraro
Comment 5 2014-01-23 22:06:10 PST
Landed <http://trac.webkit.org/changeset/162691>.
Note You need to log in before you can comment on or make changes to this bug.