| Summary: | IDB: Implement SQLite backing store 'get' support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, andersca, ap, commit-queue, jsbell, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 124521 | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2014-01-23 12:07:50 PST
Created attachment 222048 [details]
Patch v1
Comment on attachment 222048 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511 > + std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg); these seem like one of the canonical "pure win" places to use auto. (In reply to comment #2) > (From update of attachment 222048 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review > > > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511 > > + std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg); > > these seem like one of the canonical "pure win" places to use auto. I agree. thx |