Bug 127502

Summary: IDB: Implement SQLite backing store 'get' support
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, andersca, ap, commit-queue, jsbell, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 thorton: review+

Description Brady Eidson 2014-01-23 12:07:50 PST
IDB: Implement SQLite backing store 'get' support
Comment 1 Brady Eidson 2014-01-23 17:19:00 PST
Created attachment 222048 [details]
Patch v1
Comment 2 Tim Horton 2014-01-23 19:42:57 PST
Comment on attachment 222048 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review

> Source/WebCore/platform/sql/SQLiteDatabase.cpp:511
> +    std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg);

these seem like one of the canonical "pure win" places to use auto.
Comment 3 Brady Eidson 2014-01-23 19:44:03 PST
(In reply to comment #2)
> (From update of attachment 222048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review
> 
> > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511
> > +    std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg);
> 
> these seem like one of the canonical "pure win" places to use auto.

I agree.  thx
Comment 4 Brady Eidson 2014-01-23 19:48:26 PST
http://trac.webkit.org/changeset/162682