Bug 127502

Summary: IDB: Implement SQLite backing store 'get' support
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, andersca, ap, commit-queue, jsbell, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 thorton: review+

Brady Eidson
Reported Thursday, January 23, 2014 8:07:50 PM UTC
IDB: Implement SQLite backing store 'get' support
Attachments
Patch v1 (20.86 KB, patch)
2014-01-23 17:19 PST, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 Friday, January 24, 2014 1:19:00 AM UTC
Created attachment 222048 [details] Patch v1
Tim Horton
Comment 2 Friday, January 24, 2014 3:42:57 AM UTC
Comment on attachment 222048 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511 > + std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg); these seem like one of the canonical "pure win" places to use auto.
Brady Eidson
Comment 3 Friday, January 24, 2014 3:44:03 AM UTC
(In reply to comment #2) > (From update of attachment 222048 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review > > > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511 > > + std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg); > > these seem like one of the canonical "pure win" places to use auto. I agree. thx
Brady Eidson
Comment 4 Friday, January 24, 2014 3:48:26 AM UTC
http://trac.webkit.org/changeset/162682
Note You need to log in before you can comment on or make changes to this bug.