Bug 127496

Summary:

[EFL][WK2] Debug buildfix

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2014-01-23 10:46:11 PST

On Ubuntu 12.04 with GCC 4.7.3 (Ubuntu/Linaro 4.7.3-2ubuntu1~12.04)
I got the following build failure only in debug mode:

$ Tools/Scripts/build-webkit --debug --efl --cmakeargs="-DSHARED_CORE=ON"

Linking CXX shared library ../../lib/libewebkit2.so
CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o: In function `WebKit::WebPage::sessionID() const':
/home/ossy/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2130: undefined reference to `WebKit::SessionTracker::legacyPrivateSessionID'
/home/ossy/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2130: undefined reference to `WebKit::SessionTracker::defaultSessionID'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/libewebkit2.so.0.1.0] Error 1
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
make: *** [all] Error 2

Comment 1 Csaba Osztrogonác 2014-01-23 10:50:03 PST

Created attachment 222002 [details]
Patch

Comment 2 Gyuyoung Kim 2014-01-24 03:55:04 PST

*** Bug 127549 has been marked as a duplicate of this bug. ***

Comment 3 Csaba Osztrogonác 2014-01-24 03:59:12 PST

landed in r162699

Comment 4 Gyuyoung Kim 2014-01-24 04:01:37 PST

(In reply to comment #3)
> landed in r162699

This patch belong to WK2 owner area, this patch is to fix build error. So, I believe this doesn't violate WK2 owner policy.

Comment 5 Csaba Osztrogonác 2014-01-24 04:03:37 PST

Trivial buildfixes don't need owner review.

Comment 6 Gyuyoung Kim 2014-01-24 04:04:40 PST

(In reply to comment #5)
> Trivial buildfixes don't need owner review.

I see. :D Thanks.