Bug 127483

Summary:

Merge Chromium TextTrack cleanups

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, japhet, jeremyj-wk, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	darin: review+

Description Eric Carlson 2014-01-23 08:37:13 PST

Merge some of the Chromium TextTrack cleanups that have happened since the fork.

Comment 1 Eric Carlson 2014-01-23 08:50:00 PST

Created attachment 221986 [details]
Proposed patch

Comment 2 Darin Adler 2014-01-23 09:46:53 PST

Comment on attachment 221986 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221986&action=review

> Source/WebCore/html/HTMLTrackElement.h:91
> +    bool canLoadUrl(const URL&);

Should be named canLoadURL.

> Source/WebCore/loader/TextTrackLoader.cpp:79
> +        m_resource = 0;

nullptr

Comment 3 Eric Carlson 2014-01-27 07:03:09 PST

Committed r162836: http://trac.webkit.org/changeset/162836