Bug 127470

Summary:

Remove unused RuntimeEnabledFeatures

Product:

WebKit

Reporter:

Allan Sandfeld Jensen <allan.jensen>

Component:

Bindings

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review-

Description Allan Sandfeld Jensen 2014-01-23 01:14:47 PST

Remove the unused indexedDBEnabled(), webSocketEnabled() and sharedWorkerEnabled(). Their presence is only confusing.

Comment 1 Allan Sandfeld Jensen 2014-01-23 01:16:47 PST

Created attachment 221960 [details]
Patch

Comment 2 Alexey Proskuryakov 2014-01-23 14:38:07 PST

Comment on attachment 221960 [details]
Patch

EWS is red, saying that these are used in generated code:

/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:4922:51: error: no member named 'webSocketEnabled' in 'WebCore::RuntimeEnabledFeatures'
    if (!RuntimeEnabledFeatures::sharedFeatures().webSocketEnabled())
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:8984:51: error: no member named 'sharedWorkerEnabled' in 'WebCore::RuntimeEnabledFeatures'
    if (!RuntimeEnabledFeatures::sharedFeatures().sharedWorkerEnabled())
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

IndexedDB is disabled IIRC, otherwise it would almost certainly fail too.