Bug 127457

Summary: [Win] Update project and solution files for 64-bit builds
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, commit-queue, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch against branch.
none
Patch against ToT eric.carlson: review+, bfulgham: commit-queue+

Brent Fulgham
Reported 2014-01-22 17:41:23 PST
This patch updates several projects, solutions, and source code to allow an end-to-end internal Apple build of WebKit in 64-bit mode.
Attachments
Patch against branch. (91.24 KB, patch)
2014-01-22 17:56 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch against ToT (32.18 KB, patch)
2014-01-22 20:32 PST, Brent Fulgham 		eric.carlson: review+
bfulgham: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-01-22 17:56:36 PST
Created attachment 221930 [details] Patch against branch.
Brent Fulgham
Comment 2 2014-01-22 20:32:51 PST
Created attachment 221940 [details] Patch against ToT
WebKit Commit Bot
Comment 3 2014-01-22 20:35:02 PST
Attachment 221940 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:231: edge_dash_lengths is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:232: middle_dash_lengths is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:233: edge_offset is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:234: middle_offset is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 4 2014-01-23 09:40:40 PST
Comment on attachment 221940 [details] Patch against ToT rs=me
Brent Fulgham
Comment 5 2014-01-23 10:09:45 PST
Committed r162621: <http://trac.webkit.org/changeset/162621>
Note You need to log in before you can comment on or make changes to this bug.