Bug 127456

Summary: Make visibleContentRect() return actualVisibleContentRect() on iOS most of the time
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, psolanki, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch koivisto: review+

Simon Fraser (smfr)
Reported 2014-01-22 17:33:07 PST
Make visibleContentRect() return actualVisibleContentRect() on iOS most of the time
Attachments
Patch (34.97 KB, patch)
2014-01-22 17:51 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (36.80 KB, patch)
2014-01-22 21:11 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (37.12 KB, patch)
2014-01-22 22:05 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (55.21 KB, patch)
2014-01-23 16:29 PST, Simon Fraser (smfr) 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-01-22 17:51:04 PST
Created attachment 221928 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-01-22 21:11:00 PST
Created attachment 221944 [details] Patch
Simon Fraser (smfr)
Comment 3 2014-01-22 22:05:46 PST
Created attachment 221947 [details] Patch
Antti Koivisto
Comment 4 2014-01-23 12:11:01 PST
Comment on attachment 221947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221947&action=review > Source/WebCore/platform/ScrollView.h:162 > + virtual IntRect visibleContentRect(VisibleContentRectIncludesScrollbars = ExcludeScrollbars, VisibleContentRectBehavior = ContentsVisibleRect) const override; Default values are nasty in general and having more than one especially awkward. Considering that very few call sites want to include the scrollbars I think you should add a separate visibleContentRectIncludingScrollbars() function.
Simon Fraser (smfr)
Comment 5 2014-01-23 16:29:16 PST
Created attachment 222039 [details] Patch
Simon Fraser (smfr)
Comment 6 2014-01-23 16:35:29 PST
https://trac.webkit.org/r162663
Note You need to log in before you can comment on or make changes to this bug.