| Summary: | Make visibleContentRect() return actualVisibleContentRect() on iOS most of the time | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | koivisto, psolanki, simon.fraser, thorton | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2014-01-22 17:33:07 PST
Created attachment 221928 [details]
Patch
Created attachment 221944 [details]
Patch
Created attachment 221947 [details]
Patch
Comment on attachment 221947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221947&action=review > Source/WebCore/platform/ScrollView.h:162 > + virtual IntRect visibleContentRect(VisibleContentRectIncludesScrollbars = ExcludeScrollbars, VisibleContentRectBehavior = ContentsVisibleRect) const override; Default values are nasty in general and having more than one especially awkward. Considering that very few call sites want to include the scrollbars I think you should add a separate visibleContentRectIncludingScrollbars() function. Created attachment 222039 [details]
Patch
|