Bug 127450

Summary: Update JS whitespace definition for changes in Unicode 6.3
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: JavaScriptCoreAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, oliver
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
none
without tabs
none
part 2 none

Alexey Proskuryakov
Reported 2014-01-22 15:32:26 PST
Unicode 6.3 changes character type of U+180E MONGOLIAN VOWEL SEPARATOR, so that it's no longer whitespace for the purposes of number parsing. But EcmaScript says that we should keep recognizing it as whitespace, because that's why Unicode 3.0 said: "ECMAScript implementations must recognise all of the white space characters defined in Unicode 3.0. Later editions of the Unicode Standard may define other white space characters. ECMAScript implementations may recognise white space characters from later editions of the Unicode Standard." <rdar://15863457>
Attachments
proposed fix (1.53 KB, patch)
2014-01-22 15:36 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
without tabs (1.54 KB, patch)
2014-01-22 15:46 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
part 2 (1.41 KB, patch)
2014-02-03 12:43 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-01-22 15:36:30 PST
Created attachment 221916 [details] proposed fix
WebKit Commit Bot
Comment 2 2014-01-22 15:39:27 PST
Attachment 221916 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2014-01-22 15:46:15 PST
Created attachment 221918 [details] without tabs
WebKit Commit Bot
Comment 4 2014-01-22 17:31:26 PST
Comment on attachment 221918 [details] without tabs Clearing flags on attachment: 221918 Committed r162575: <http://trac.webkit.org/changeset/162575>
WebKit Commit Bot
Comment 5 2014-01-22 17:31:28 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2014-02-03 12:42:21 PST
There is one more place to update.
Alexey Proskuryakov
Comment 7 2014-02-03 12:43:44 PST
Created attachment 223009 [details] part 2
WebKit Commit Bot
Comment 8 2014-02-03 13:48:08 PST
Comment on attachment 223009 [details] part 2 Clearing flags on attachment: 223009 Committed r163325: <http://trac.webkit.org/changeset/163325>
WebKit Commit Bot
Comment 9 2014-02-03 13:48:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.