Bug 127444

Summary: Add WKWebView class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2014-01-22 13:41:56 PST 
Add WKWebView class
Comment 1 Anders Carlsson 2014-01-22 13:43:09 PST 
Created attachment 221901 [details]
Patch
Comment 2 mitz 2014-01-22 14:05:29 PST 
Comment on attachment 221901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221901&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:65
> +- (instancetype)initWithFrame:(CGRect)frame configuration:(WKWebViewConfiguration *)configuration NS_DESIGNATED_INITIALIZER;

I think you meant WK_DESIGNATED_INITIALIZER.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:37
> +- (instancetype)initWithFrame:(CGRect)frame configuration:(WKWebViewConfiguration *)configuration

Please add a FIXME about overriding -initWithFrame: to do what the header says it should do.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:42
> +    _configuration = adoptNS([configuration copy]);

Please add a FIXME here about filling in a configuration that has nil properties with concrete default instances.
Comment 3 Anders Carlsson 2014-01-22 14:12:14 PST 
Committed r162554: <http://trac.webkit.org/changeset/162554>