Bug 127444 - Add WKWebView class
Summary: Add WKWebView class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 13:41 PST by Anders Carlsson
Modified: 2014-01-22 14:12 PST (History)
0 users

See Also:

Attachments
Patch (10.65 KB, patch)
2014-01-22 13:43 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-22 13:41:56 PST 
Add WKWebView class
Comment 1 Anders Carlsson 2014-01-22 13:43:09 PST 
Created attachment 221901 [details]
Patch
Comment 2 mitz 2014-01-22 14:05:29 PST 
Comment on attachment 221901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221901&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:65
> +- (instancetype)initWithFrame:(CGRect)frame configuration:(WKWebViewConfiguration *)configuration NS_DESIGNATED_INITIALIZER;

I think you meant WK_DESIGNATED_INITIALIZER.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:37
> +- (instancetype)initWithFrame:(CGRect)frame configuration:(WKWebViewConfiguration *)configuration

Please add a FIXME about overriding -initWithFrame: to do what the header says it should do.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:42
> +    _configuration = adoptNS([configuration copy]);

Please add a FIXME here about filling in a configuration that has nil properties with concrete default instances.
Comment 3 Anders Carlsson 2014-01-22 14:12:14 PST 
Committed r162554: <http://trac.webkit.org/changeset/162554>