Bug 127442

Summary: PutByIdDirect in FTL
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Adds PutByIdDirect capabilities to FTL
none
Adds PutByIdDirect capabilities to FTL
fpizlo: review-, fpizlo: commit-queue-
PutByIdDirect in FTL patch fpizlo: review+

Matthew Mirman
Reported 2014-01-22 12:31:48 PST
patch forthcoming
Attachments
Adds PutByIdDirect capabilities to FTL (3.02 KB, patch)
2014-01-22 12:35 PST, Matthew Mirman 		no flags
DetailsFormatted DiffDiff
Adds PutByIdDirect capabilities to FTL (3.04 KB, patch)
2014-01-22 12:41 PST, Matthew Mirman 		fpizlo: review-
fpizlo: commit-queue-
DetailsFormatted DiffDiff
PutByIdDirect in FTL patch (2.61 KB, patch)
2014-01-24 12:44 PST, Matthew Mirman 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matthew Mirman
Comment 1 2014-01-22 12:35:25 PST
Created attachment 221892 [details] Adds PutByIdDirect capabilities to FTL also adds a test for PutById
WebKit Commit Bot
Comment 2 2014-01-22 12:36:53 PST
Attachment 221892 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyiddirect.js:2: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyiddirect.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyid.js:5: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyid.js:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Matthew Mirman
Comment 3 2014-01-22 12:41:56 PST
Created attachment 221893 [details] Adds PutByIdDirect capabilities to FTL Also adds a test for PutById.
Filip Pizlo
Comment 4 2014-01-24 12:36:18 PST
Comment on attachment 221893 [details] Adds PutByIdDirect capabilities to FTL View in context: https://bugs.webkit.org/attachment.cgi?id=221893&action=review This looks good but please revert the whitespace changes. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-30 > - Revert! We generally try to minimize whitespace changes, especially in otherwise small patches. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1518 > + Revert!
Matthew Mirman
Comment 5 2014-01-24 12:44:37 PST
Created attachment 222140 [details] PutByIdDirect in FTL patch Removed whitespace, added test for putbyid.
Filip Pizlo
Comment 6 2014-01-24 13:15:29 PST
Landed in http://trac.webkit.org/changeset/162717
Note You need to log in before you can comment on or make changes to this bug.