| Summary: | PutByIdDirect in FTL | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Mirman <mmirman> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Matthew Mirman
2014-01-22 12:31:48 PST
Created attachment 221892 [details]
Adds PutByIdDirect capabilities to FTL
also adds a test for PutById
Attachment 221892 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyiddirect.js:2: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyiddirect.js:11: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyid.js:5: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyid.js:6: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 221893 [details]
Adds PutByIdDirect capabilities to FTL
Also adds a test for PutById.
Comment on attachment 221893 [details] Adds PutByIdDirect capabilities to FTL View in context: https://bugs.webkit.org/attachment.cgi?id=221893&action=review This looks good but please revert the whitespace changes. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-30 > - Revert! We generally try to minimize whitespace changes, especially in otherwise small patches. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1518 > + Revert! Created attachment 222140 [details]
PutByIdDirect in FTL patch
Removed whitespace, added test for putbyid.
Landed in http://trac.webkit.org/changeset/162717 |