Add WKProcessClass class

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Add WKProcessClass class

[Anders Carlsson]

Created attachment 221877 [details]
Patch

[Anders Carlsson]

Created attachment 221878 [details]
Patch

[Anders Carlsson]

Created attachment 221880 [details]
Patch

[Anders Carlsson]

Committed r162541: <http://trac.webkit.org/changeset/162541>

[Darin Adler]

Comment on attachment 221880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221880&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:42
> +    _configuration = adoptNS([configuration copy]);

copy

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:51
> +    return [[_configuration copy] autorelease];

Why do we need copy/autorelease here if we did a copy in the initializer.

[Anders Carlsson]

(In reply to comment #5)
> (From update of attachment 221880 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221880&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:42
> > +    _configuration = adoptNS([configuration copy]);
> 
> copy

From the documentation:

        The initializer copies
        @link //apple_ref/doc/methodparam/WKProcessClass/initWithConfiguration:/configuration
        configuration@/link, so mutating it after initialization has no effect on the
        @link WKProcessClass @/link instance.

> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:51
> > +    return [[_configuration copy] autorelease];
> 
> Why do we need copy/autorelease here if we did a copy in the initializer.

From the documentation:

/*! @abstract A copy of the configuration with which the @link WKProcessClass @/link was
        initialized.
*/