Summary: | PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | Assignee: | Tim Horton <thorton> | |||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, gordon_sheridan, jberlin, sam | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-01-22 01:19:56 PST
Created attachment 221837 [details]
patch
I hate adding more things to findPlugin and pluginLoadPolicy but it is the most straightforward way to go.
Created attachment 221839 [details]
rebase
Comment on attachment 221839 [details] rebase View in context: https://bugs.webkit.org/attachment.cgi?id=221839&action=review > Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h:396 > + // Version 4. > + WKPageWebGLLoadPolicyCallback webGLLoadPolicy; > + > + // Version 5. > + WKPagePluginLoadPolicyCallback pluginLoadPolicy; I'm not clear if we need to rev for this. (In reply to comment #3) > (From update of attachment 221839 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221839&action=review > > > Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h:396 > > + // Version 4. > > + WKPageWebGLLoadPolicyCallback webGLLoadPolicy; > > + > > + // Version 5. > > + WKPagePluginLoadPolicyCallback pluginLoadPolicy; > > I'm not clear if we need to rev for this. Looks like you’re right. Part of this was reverted in https://trac.webkit.org/r162883 |