Bug 127415

Summary: PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, gordon_sheridan, jberlin, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
rebase sam: review+

Description Tim Horton 2014-01-22 01:19:56 PST 
If there is an external PDF plugin but it's blocked, we should still load in PDFPlugin, with a context menu option to perform the equivalent of the unavailable plugin button (thus allowing the client to unblock the plugin).

<rdar://problem/12482452>
Comment 1 Tim Horton 2014-01-22 01:36:39 PST 
Created attachment 221837 [details]
patch

I hate adding more things to findPlugin and pluginLoadPolicy but it is the most straightforward way to go.
Comment 2 Tim Horton 2014-01-22 01:43:05 PST 
Created attachment 221839 [details]
rebase
Comment 3 Sam Weinig 2014-01-23 07:47:33 PST 
Comment on attachment 221839 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=221839&action=review

> Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h:396
> +    // Version 4.
> +    WKPageWebGLLoadPolicyCallback                                       webGLLoadPolicy;
> +
> +    // Version 5.
> +    WKPagePluginLoadPolicyCallback                                      pluginLoadPolicy;

I'm not clear if we need to rev for this.
Comment 4 Tim Horton 2014-01-23 11:08:32 PST 
(In reply to comment #3)
> (From update of attachment 221839 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221839&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h:396
> > +    // Version 4.
> > +    WKPageWebGLLoadPolicyCallback                                       webGLLoadPolicy;
> > +
> > +    // Version 5.
> > +    WKPagePluginLoadPolicyCallback                                      pluginLoadPolicy;
> 
> I'm not clear if we need to rev for this.

Looks like you’re right.
Comment 5 Tim Horton 2014-01-23 11:27:10 PST 
http://trac.webkit.org/changeset/162629
Comment 6 Tim Horton 2014-01-27 16:03:39 PST 
Part of this was reverted in https://trac.webkit.org/r162883