Bug 127404

Summary:

Subpixel Layout: SimpleLineLayout needs more position rounding to match InlineFlowBox layout.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

126283, 124784

Attachments:

Description	Flags
Patch	none

Description zalan 2014-01-21 21:05:29 PST

similar to InlineFlowBox

InlineFlowBox::placeBoxesInBlockDirection

        const FontMetrics& fontMetrics = lineStyle().fontMetrics();
        // RootInlineBoxes are always placed on at pixel boundaries in their logical y direction. Not doing
        // so results in incorrect rendering of text decorations, most notably underlines.
        setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType)));


missing roundings are in:
 RunResolver::Run::baseline()
 RunResolver::Run::rect()

Comment 1 zalan 2014-01-22 12:53:42 PST

Created attachment 221894 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-22 13:59:04 PST

Comment on attachment 221894 [details]
Patch

Clearing flags on attachment: 221894

Committed r162553: <http://trac.webkit.org/changeset/162553>

Comment 3 WebKit Commit Bot 2014-01-22 13:59:07 PST

All reviewed patches have been landed.  Closing bug.