Bug 127404 - Subpixel Layout: SimpleLineLayout needs more position rounding to match InlineFlowBox layout.
Summary: Subpixel Layout: SimpleLineLayout needs more position rounding to match Inlin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: 126283 124784
  Show dependency treegraph
 
Reported: 2014-01-21 21:05 PST by zalan
Modified: 2014-01-22 13:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (44.03 KB, patch)
2014-01-22 12:53 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-21 21:05:29 PST
similar to InlineFlowBox

InlineFlowBox::placeBoxesInBlockDirection

        const FontMetrics& fontMetrics = lineStyle().fontMetrics();
        // RootInlineBoxes are always placed on at pixel boundaries in their logical y direction. Not doing
        // so results in incorrect rendering of text decorations, most notably underlines.
        setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType)));


missing roundings are in:
 RunResolver::Run::baseline()
 RunResolver::Run::rect()
Comment 1 zalan 2014-01-22 12:53:42 PST
Created attachment 221894 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-22 13:59:04 PST
Comment on attachment 221894 [details]
Patch

Clearing flags on attachment: 221894

Committed r162553: <http://trac.webkit.org/changeset/162553>
Comment 3 WebKit Commit Bot 2014-01-22 13:59:07 PST
All reviewed patches have been landed.  Closing bug.