RESOLVED FIXED 127404
Subpixel Layout: SimpleLineLayout needs more position rounding to match InlineFlowBox layout. 
https://bugs.webkit.org/show_bug.cgi?id=127404
Summary Subpixel Layout: SimpleLineLayout needs more position rounding to match Inlin...
zalan
Reported 2014-01-21 21:05:29 PST
similar to InlineFlowBox InlineFlowBox::placeBoxesInBlockDirection const FontMetrics& fontMetrics = lineStyle().fontMetrics(); // RootInlineBoxes are always placed on at pixel boundaries in their logical y direction. Not doing // so results in incorrect rendering of text decorations, most notably underlines. setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType))); missing roundings are in: RunResolver::Run::baseline() RunResolver::Run::rect()
Attachments
Patch (44.03 KB, patch)
2014-01-22 12:53 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-01-22 12:53:42 PST
Created attachment 221894 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-22 13:59:04 PST
Comment on attachment 221894 [details] Patch Clearing flags on attachment: 221894 Committed r162553: <http://trac.webkit.org/changeset/162553>
WebKit Commit Bot
Comment 3 2014-01-22 13:59:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.