Bug 127403

Summary: Add a minimalistic SPI to control the layout size outside of WKView
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ian, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Benjamin Poulain
Reported 2014-01-21 20:58:39 PST
Add a minimalistic SPI to control the layout size outside of WKView
Attachments
Patch (3.73 KB, patch)
2014-01-21 21:01 PST, Benjamin Poulain 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-01-21 21:01:14 PST
Created attachment 221826 [details] Patch
Ian Henderson
Comment 2 2014-01-21 21:04:16 PST
Comment on attachment 221826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221826&action=review Looks good to me either way. > Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:45 > +- (void)overrideMinimumLayoutSize:(CGSize)forcedSize; Might this work better as a property? E.g. @property (nonatomic) CGSize minimumLayoutSizeOverride;
Ian Henderson
Comment 3 2014-01-21 21:04:43 PST
(In reply to comment #2) > (From update of attachment 221826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221826&action=review > > Looks good to me either way. > > > Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:45 > > +- (void)overrideMinimumLayoutSize:(CGSize)forcedSize; > > Might this work better as a property? E.g. > > @property (nonatomic) CGSize minimumLayoutSizeOverride; The "looks good to me either way" was meant to be after that comment…
Sam Weinig
Comment 4 2014-01-21 21:25:02 PST
Comment on attachment 221826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221826&action=review >>> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:45 >>> +- (void)overrideMinimumLayoutSize:(CGSize)forcedSize; >> >> Might this work better as a property? E.g. >> >> @property (nonatomic) CGSize minimumLayoutSizeOverride; > > The "looks good to me either way" was meant to be after that comment… I agree, a property might be better. r=me.
Benjamin Poulain
Comment 5 2014-01-22 21:01:00 PST
Committed r162590: <http://trac.webkit.org/changeset/162590>
Note You need to log in before you can comment on or make changes to this bug.