Bug 127394

Summary: JSC needs to be able to parse DWARF debug_line info
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, fpizlo, ggaren, gyuyoung.kim, rakuco, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Mark Hahnenberg
Reported 2014-01-21 18:18:57 PST
If we want to encode IR maps in the DWARF debug line info metadata generated by LLVM, we'll need to know how to decode the .debug_line DWARF section.
Attachments
Patch (23.09 KB, patch)
2014-01-21 18:45 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (23.91 KB, patch)
2014-02-04 10:08 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-01-21 18:45:23 PST
Created attachment 221819 [details] Patch
Mark Hahnenberg
Comment 2 2014-01-21 18:48:21 PST
Comment on attachment 221819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review > Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:281 > + /* Special opcodes */ Unindent.
Sam Weinig
Comment 3 2014-01-21 21:25:43 PST
Super-fun!
Geoffrey Garen
Comment 4 2014-01-28 09:15:01 PST
Comment on attachment 221819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review r=me > Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:42 > + T result = *(T*)program; This should be "T result = *static_cast<const T*&>(program);"
Mark Hahnenberg
Comment 5 2014-02-04 10:08:01 PST
Created attachment 223128 [details] Patch
Mark Hahnenberg
Comment 6 2014-02-04 10:08:12 PST
(In reply to comment #5) > Created an attachment (id=223128) [details] > Patch EWS fodder.
Mark Hahnenberg
Comment 7 2014-02-04 10:17:49 PST
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=223128) [details] [details] > > Patch > > EWS fodder. Also forgot to fix the casts.
Geoffrey Garen
Comment 8 2014-02-04 12:37:28 PST
Comment on attachment 223128 [details] Patch r=me
Mark Hahnenberg
Comment 9 2014-02-04 13:22:34 PST
Committed r163397: <http://trac.webkit.org/changeset/163397>
Note You need to log in before you can comment on or make changes to this bug.