Bug 127394

Summary: JSC needs to be able to parse DWARF debug_line info
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, fpizlo, ggaren, gyuyoung.kim, rakuco, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Description Mark Hahnenberg 2014-01-21 18:18:57 PST 
If we want to encode IR maps in the DWARF debug line info metadata generated by LLVM, we'll need to know how to decode the .debug_line DWARF section.
Comment 1 Mark Hahnenberg 2014-01-21 18:45:23 PST 
Created attachment 221819 [details]
Patch
Comment 2 Mark Hahnenberg 2014-01-21 18:48:21 PST 
Comment on attachment 221819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review

> Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:281
> +        /* Special opcodes */

Unindent.
Comment 3 Sam Weinig 2014-01-21 21:25:43 PST 
Super-fun!
Comment 4 Geoffrey Garen 2014-01-28 09:15:01 PST 
Comment on attachment 221819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review

r=me

> Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:42
> +    T result = *(T*)program;

This should be "T result = *static_cast<const T*&>(program);"
Comment 5 Mark Hahnenberg 2014-02-04 10:08:01 PST 
Created attachment 223128 [details]
Patch
Comment 6 Mark Hahnenberg 2014-02-04 10:08:12 PST 
(In reply to comment #5)
> Created an attachment (id=223128) [details]
> Patch

EWS fodder.
Comment 7 Mark Hahnenberg 2014-02-04 10:17:49 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=223128) [details] [details]
> > Patch
> 
> EWS fodder.

Also forgot to fix the casts.
Comment 8 Geoffrey Garen 2014-02-04 12:37:28 PST 
Comment on attachment 223128 [details]
Patch

r=me
Comment 9 Mark Hahnenberg 2014-02-04 13:22:34 PST 
Committed r163397: <http://trac.webkit.org/changeset/163397>