Bug 127363

Summary: WebKit2 View Gestures: Fluid back-forward swipe
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mkwst, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127437, 127438    
Bug Blocks:    
Attachments:
Description Flags
patch
none
take two
none
take three
none
mac build fix
none
patch (won't build b/c of dependencies)
none
patch andersca: review+

Tim Horton
Reported 2014-01-21 12:27:03 PST
Implement fluid swipe as WebKit2 SPI. The initial implementation will be off by default, and has a few important features missing (I'll file bugs for them when this lands), including capping the number of snapshots, making them purgeable, and supporting web content overriding the swipe.
Attachments
patch (73.07 KB, patch)
2014-01-21 16:51 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
take two (54.11 KB, patch)
2014-01-21 17:32 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
take three (54.99 KB, patch)
2014-01-21 18:05 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
mac build fix (55.00 KB, patch)
2014-01-22 11:23 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (won't build b/c of dependencies) (28.73 KB, patch)
2014-01-22 13:10 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (35.04 KB, patch)
2014-01-24 16:27 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-01-21 16:51:42 PST
Created attachment 221809 [details] patch
WebKit Commit Bot
Comment 2 2014-01-21 16:53:02 PST
Attachment 221809 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:47: The parameter name "webPageProxy" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-01-21 16:55:41 PST
I'm going to do the rename in a separate patch to reduce the size.
Tim Horton
Comment 4 2014-01-21 17:32:43 PST
Created attachment 221814 [details] take two
Tim Horton
Comment 5 2014-01-21 18:05:17 PST
Created attachment 221817 [details] take three
Tim Horton
Comment 6 2014-01-22 11:23:22 PST
Created attachment 221882 [details] mac build fix
Tim Horton
Comment 7 2014-01-22 12:10:14 PST
I'm splitting this patch up.
Tim Horton
Comment 8 2014-01-22 13:10:10 PST
Created attachment 221898 [details] patch (won't build b/c of dependencies)
Tim Horton
Comment 9 2014-01-24 16:27:51 PST
Created attachment 222166 [details] patch
Tim Horton
Comment 10 2014-01-24 23:50:16 PST
Comment on attachment 222166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=222166&action=review > Source/WebKit2/UIProcess/mac/ViewGestureController.mm:74 > + whoops, I forgot about this before posting the patch (and left the comment when I saw another patch in-flight). will fix
Anders Carlsson
Comment 11 2014-01-27 11:12:21 PST
Comment on attachment 222166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=222166&action=review >> Source/WebKit2/UIProcess/mac/ViewGestureController.mm:74 >> + > > whoops, I forgot about this before posting the patch (and left the comment when I saw another patch in-flight). will fix 3_s!
Tim Horton
Comment 12 2014-01-27 12:18:19 PST
http://trac.webkit.org/changeset/162853
Note You need to log in before you can comment on or make changes to this bug.