Summary: | WebKit2 View Gestures: Fluid back-forward swipe | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | andersca, commit-queue, mkwst, sam, simon.fraser | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 127437, 127438 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Tim Horton
2014-01-21 12:27:03 PST
Created attachment 221809 [details]
patch
Attachment 221809 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:47: The parameter name "webPageProxy" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I'm going to do the rename in a separate patch to reduce the size. Created attachment 221814 [details]
take two
Created attachment 221817 [details]
take three
Created attachment 221882 [details]
mac build fix
I'm splitting this patch up. Created attachment 221898 [details]
patch (won't build b/c of dependencies)
Created attachment 222166 [details]
patch
Comment on attachment 222166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=222166&action=review > Source/WebKit2/UIProcess/mac/ViewGestureController.mm:74 > + whoops, I forgot about this before posting the patch (and left the comment when I saw another patch in-flight). will fix Comment on attachment 222166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=222166&action=review >> Source/WebKit2/UIProcess/mac/ViewGestureController.mm:74 >> + > > whoops, I forgot about this before posting the patch (and left the comment when I saw another patch in-flight). will fix 3_s! |