Bug 127346

Summary:

Wrong struct size when CSS_IMAGE_ORIENTATION and CSS3_TEXT_DECORATION are enabled.

Product:

WebKit

Reporter:

László Langó <llango.u-szeged>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

127351

Bug Blocks:

Attachments:

Description	Flags
Patch	none

László Langó

Reported 2014-01-21 07:53:28 PST

Source/WebCore/rendering/style/StyleRareInheritedData.cpp:68:1: error: static assertion failed: StyleRareInheritedData_should_bit_pack

Attachments
Patch (1.39 KB, patch) 2014-01-21 08:06 PST, László Langó	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

László Langó

Comment 1 2014-01-21 08:06:26 PST

Created attachment 221746 [details] Patch

WebKit Commit Bot

Comment 2 2014-01-21 09:01:39 PST

Comment on attachment 221746 [details] Patch Clearing flags on attachment: 221746 Committed r162445: <http://trac.webkit.org/changeset/162445>

WebKit Commit Bot

Comment 3 2014-01-21 09:01:43 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 4 2014-01-21 09:17:08 PST

Re-opened since this is blocked by bug 127351

Csaba Osztrogonác

Comment 5 2014-01-21 09:19:48 PST

(In reply to comment #4) > Re-opened since this is blocked by bug 127351 Rolled out, because it broke the 32 bit GTK build: ../../Source/WebCore/rendering/style/StyleRareInheritedData.cpp:68:1: error: static assertion failed: StyleRareInheritedData_should_bit_pack COMPILE_ASSERT(sizeof(StyleRareInheritedData) == sizeof(SameSizeAsStyleRareInheritedData), StyleRareInheritedData_should_bit_pack); It seems there are different sized padding on 32 and 64 bit :-/

Note You need to log in before you can comment on or make changes to this bug.