Summary: | Web Inspector: Add the recording button back to the Timelines sidebar | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Timothy Hatcher
2014-01-20 15:01:46 PST
Created attachment 221699 [details]
Patch
Comment on attachment 221699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221699&action=review r=me > Source/WebInspectorUI/UserInterface/TimelineContentView.js:311 > + // We have a current time alredy, so we likely need to jump into the future to a better current time. Typo: alredy => already > Source/WebInspectorUI/UserInterface/TimelineContentView.js:378 > _recordingReset: function(event) > { > - this._startTimeNeedsReset = true; > this._currentTime = NaN; > > + if (!this._updating) { > + // Force the time ruler and views to reset to 0. > + this._startTimeNeedsReset = true; > + this._updateTimes(0, 0, 0); > + } > + > + this._lastUpdateTimestamp = NaN; > + this._startTimeNeedsReset = true; Should this also delete this._waitingToResetCurrentTime if it was waiting? Seeing as we just deleted currentTime. Does the main navigator forward/back buttons update as expected? This could ravage the back/forward list of views, just double check that still works as expected. |