Bug 127278 – Move the webdatabase module source code to std::unique_ptr

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

Move the webdatabase module source code to std::unique_ptr

[Zan Dobersek]

Created attachment 221641 [details]
Patch

[WebKit Commit Bot]

Attachment 221641 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp:86:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Created attachment 221722 [details]
Patch

[WebKit Commit Bot]

Attachment 221722 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp:85:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

This looks fine to me. I think a C++11 expert should confirm before we land.

[Zan Dobersek]

Created attachment 222984 [details]
Patch for landing

Running the patch through EWS one more time.

[WebKit Commit Bot]

Attachment 222984 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp:85:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 221722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221722&action=review

> Source/WebCore/Modules/webdatabase/SQLStatement.h:52
> +    SQLStatement(Database*, PassRefPtr<SQLStatementCallback>, PassRefPtr<SQLStatementErrorCallback>);

Seems like this should take a Database& rather than a Database*.

> Source/WebCore/Modules/webdatabase/SQLStatementBackend.h:71
> +    std::unique_ptr<AbstractSQLStatement> m_frontend;

Annoying that this smushes two words “front end” into one word “frontend”. Should be m_frontEnd. Class name should be BackEnd.

[Zan Dobersek]

(In reply to comment #8)
> (From update of attachment 221722 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221722&action=review
> 
> > Source/WebCore/Modules/webdatabase/SQLStatement.h:52
> > +    SQLStatement(Database*, PassRefPtr<SQLStatementCallback>, PassRefPtr<SQLStatementErrorCallback>);
> 
> Seems like this should take a Database& rather than a Database*.

Bug #128111.

> 
> > Source/WebCore/Modules/webdatabase/SQLStatementBackend.h:71
> > +    std::unique_ptr<AbstractSQLStatement> m_frontend;
> 
> Annoying that this smushes two words “front end” into one word “frontend”. Should be m_frontEnd. Class name should be BackEnd.

Bug #128113.

[Zan Dobersek]

Comment on attachment 222984 [details]
Patch for landing

Clearing flags on attachment: 222984

Committed r163317: <http://trac.webkit.org/changeset/163317>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.