Bug 127278

Summary: Move the webdatabase module source code to std::unique_ptr
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, commit-queue, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Zan Dobersek 2014-01-20 02:44:48 PST 
Move the webdatabase module source code to std::unique_ptr
Comment 1 Zan Dobersek 2014-01-20 02:46:16 PST 
Created attachment 221641 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-20 02:48:25 PST 
Attachment 221641 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp:86:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2014-01-20 22:57:46 PST 
Created attachment 221722 [details]
Patch
Comment 4 WebKit Commit Bot 2014-01-20 23:00:05 PST 
Attachment 221722 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp:85:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2014-01-21 12:11:17 PST 
This looks fine to me. I think a C++11 expert should confirm before we land.
Comment 6 Zan Dobersek 2014-02-03 06:59:43 PST 
Created attachment 222984 [details]
Patch for landing

Running the patch through EWS one more time.
Comment 7 WebKit Commit Bot 2014-02-03 07:09:47 PST 
Attachment 222984 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp:85:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Darin Adler 2014-02-03 09:59:15 PST 
Comment on attachment 221722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221722&action=review

> Source/WebCore/Modules/webdatabase/SQLStatement.h:52
> +    SQLStatement(Database*, PassRefPtr<SQLStatementCallback>, PassRefPtr<SQLStatementErrorCallback>);

Seems like this should take a Database& rather than a Database*.

> Source/WebCore/Modules/webdatabase/SQLStatementBackend.h:71
> +    std::unique_ptr<AbstractSQLStatement> m_frontend;

Annoying that this smushes two words “front end” into one word “frontend”. Should be m_frontEnd. Class name should be BackEnd.
Comment 9 Zan Dobersek 2014-02-03 10:57:31 PST 
(In reply to comment #8)
> (From update of attachment 221722 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221722&action=review
> 
> > Source/WebCore/Modules/webdatabase/SQLStatement.h:52
> > +    SQLStatement(Database*, PassRefPtr<SQLStatementCallback>, PassRefPtr<SQLStatementErrorCallback>);
> 
> Seems like this should take a Database& rather than a Database*.

Bug #128111.

> 
> > Source/WebCore/Modules/webdatabase/SQLStatementBackend.h:71
> > +    std::unique_ptr<AbstractSQLStatement> m_frontend;
> 
> Annoying that this smushes two words “front end” into one word “frontend”. Should be m_frontEnd. Class name should be BackEnd.

Bug #128113.
Comment 10 Zan Dobersek 2014-02-03 11:02:43 PST 
Comment on attachment 222984 [details]
Patch for landing

Clearing flags on attachment: 222984

Committed r163317: <http://trac.webkit.org/changeset/163317>
Comment 11 Zan Dobersek 2014-02-03 11:02:52 PST 
All reviewed patches have been landed.  Closing bug.