| Summary: | Web Inspector: Make the TimelineRecordTreeElement location subtitle live | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2014-01-20 00:40:22 PST
Created attachment 221629 [details]
Patch
Comment on attachment 221629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221629&action=review r=me > Source/WebInspectorUI/UserInterface/SourceCodeLocation.js:55 > + None: "none", // File name not included. > + Short: "short", // Only the file name. > + Full: "full" // Full URL is used. Nit: would be nice to line up the comments. Makes reading what each does much easier. > Source/WebInspectorUI/UserInterface/SourceCodeLocation.js:300 > + // Legacy support for when nameStyle was fullURL and a boolean. > + if (!nameStyle || typeof nameStyle === "boolean") > + nameStyle = nameStyle ? WebInspector.SourceCodeLocation.NameStyle.Full : WebInspector.SourceCodeLocation.NameStyle.Short; I'd rather we update the call sites to use the new enum and nameStyle is never a boolean. > Source/WebInspectorUI/UserInterface/TimelineRecordTreeElement.js:40 > + if (showFullLocationSubtitle) > + this._sourceCodeLocation.populateLiveDisplayLocationString(subtitle, "textContent"); Though the boolean says "showFullLocationSubtitle" it looks like this would defaults to the Short location subtitle. |