Summary: | [EFL][WK2] build fix after r162276 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||||||
Component: | WebKit EFL | Assignee: | Jinwoo Song <jinwoo7.song> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jinwoo Song
2014-01-19 16:19:22 PST
Created attachment 221598 [details]
Patch
Created attachment 221602 [details]
Patch
Comment on attachment 221602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221602&action=review > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:37 > + static std::unique_ptr<WorkItem> create(PassRefPtr<WorkQueue> workQueue, std::function<void()> function) space after void. > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:39 > return std::unique_ptr<WorkItem>(new WorkItem(workQueue, function)); Can to std::move(function) here > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:44 > + WorkItem(PassRefPtr<WorkQueue> workQueue, std::function<void()> function) space after void. > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:46 > , m_function(function) Can do std::move(function) here. > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57 > + static std::unique_ptr<TimerWorkItem> create(PassRefPtr<WorkQueue> workQueue, std::function<void()> function, double delaySeconds) Space after void. > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:60 > return std::unique_ptr<TimerWorkItem>(new TimerWorkItem(workQueue, function, currentTime() + delaySeconds)); std::move(function). > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66 > + TimerWorkItem(PassRefPtr<WorkQueue> workQueue, std::function<void()> function, double expirationTimeSeconds) space after void. > Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:67 > : WorkItem(workQueue, function) std::move(function). > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:55 > +void WorkQueue::dispatch(std::function<void()> function) space after void. > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:60 > m_dispatchQueue->dispatch(WorkItem::create(this, function)); std::move(function). > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:63 > +void WorkQueue::dispatchAfter(std::chrono::nanoseconds duration, std::function<void()> function) space after void. > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:68 > + m_dispatchQueue->dispatch(TimerWorkItem::create(this, function, duration.count() / 1000000000ULL)); std::move(function). Created attachment 221606 [details]
Patch
Applied Andersca's comments.
Attachment 221606 [details] did not pass style-queue:
ERROR: Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:37: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:44: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:52: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 7 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 221606 [details] Patch Clearing flags on attachment: 221606 Committed r162300: <http://trac.webkit.org/changeset/162300> All reviewed patches have been landed. Closing bug. |