Bug 127254

Summary:

Stop using MutexTryLocker in WebCore

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2014-01-19 11:21:55 PST

Stop using MutexTryLocker in WebCore

Comment 1 Anders Carlsson 2014-01-19 11:28:35 PST

Created attachment 221591 [details]
Patch

Comment 2 Andreas Kling 2014-01-19 11:42:09 PST

Comment on attachment 221591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221591&action=review

Nice. r=me

> Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:97
> +    for (unsigned i = 0; i < m_kernels.size(); ++i)
> +        m_kernels[i]->process(source->channel(i)->data(), destination->channel(i)->mutableData(), framesToProcess);

range for?

Comment 3 Anders Carlsson 2014-01-19 12:30:43 PST

(In reply to comment #2)
> (From update of attachment 221591 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221591&action=review
> 
> Nice. r=me
> 
> > Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:97
> > +    for (unsigned i = 0; i < m_kernels.size(); ++i)
> > +        m_kernels[i]->process(source->channel(i)->data(), destination->channel(i)->mutableData(), framesToProcess);
> 
> range for?

Still need i for source->channel(i) and destination->channel(i) :(

Comment 4 Anders Carlsson 2014-01-19 12:33:33 PST

Committed r162296: <http://trac.webkit.org/changeset/162296>