Bug 127252

Summary:

Use a strong enum for HTMLTreeBuilder::InsertionMode

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Anders Carlsson 2014-01-19 10:52:04 PST

Use a strong enum for HTMLTreeBuilder::InsertionMode

Comment 1 Anders Carlsson 2014-01-19 10:53:06 PST

Created attachment 221589 [details]
Patch

Comment 2 Anders Carlsson 2014-01-19 10:56:07 PST

Committed r162293: <http://trac.webkit.org/changeset/162293>

Comment 3 Csaba Osztrogonác 2014-01-19 14:11:22 PST

Comment on attachment 221589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221589&action=review

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037
> -        ASSERT(InColumnGroupMode);
> +        ASSERT(InsertionMode::InColumnGroup);

It broke the Apple Windows build:

     1>..\html\parser\HTMLTreeBuilder.cpp(1037): error C2675: unary '!' : 'WebCore::HTMLTreeBuilder::InsertionMode' does not define this operator or a conversion to a type acceptable to the predefined operator
     1>Done Building Project "C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED.

Comment 4 Csaba Osztrogonác 2014-01-20 02:25:16 PST

fix landed in http://trac.webkit.org/changeset/162298