WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127252
Use a strong enum for HTMLTreeBuilder::InsertionMode
https://bugs.webkit.org/show_bug.cgi?id=127252
Summary
Use a strong enum for HTMLTreeBuilder::InsertionMode
Anders Carlsson
Reported
2014-01-19 10:52:04 PST
Use a strong enum for HTMLTreeBuilder::InsertionMode
Attachments
Patch
(55.18 KB, patch)
2014-01-19 10:53 PST
,
Anders Carlsson
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-01-19 10:53:06 PST
Created
attachment 221589
[details]
Patch
Anders Carlsson
Comment 2
2014-01-19 10:56:07 PST
Committed
r162293
: <
http://trac.webkit.org/changeset/162293
>
Csaba Osztrogonác
Comment 3
2014-01-19 14:11:22 PST
Comment on
attachment 221589
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=221589&action=review
> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037 > - ASSERT(InColumnGroupMode); > + ASSERT(InsertionMode::InColumnGroup);
It broke the Apple Windows build: 1>..\html\parser\HTMLTreeBuilder.cpp(1037): error C2675: unary '!' : 'WebCore::HTMLTreeBuilder::InsertionMode' does not define this operator or a conversion to a type acceptable to the predefined operator 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED.
Csaba Osztrogonác
Comment 4
2014-01-20 02:25:16 PST
fix landed in
http://trac.webkit.org/changeset/162298
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug