| Summary: | Switch the TextCheckerClient over to using StringView everywhere | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2014-01-18 18:01:38 PST
Created attachment 221577 [details]
Patch
Attachment 221577 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebKit/win/WebCoreSupport/WebEditorClient.h:106: The parameter name "detail" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/page/EditorClient.h:176: The parameter name "detail" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 33 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 221580 [details]
Patch
Comment on attachment 221580 [details]
Patch
Pretty sure the StringView(const String&) constructor is implicit, no need for all those StringView(...) everywhere
(In reply to comment #4) > (From update of attachment 221580 [details]) > Pretty sure the StringView(const String&) constructor is implicit, no need for all those StringView(...) everywhere Yeah. Side note: I am not sure how I feel about this patch yet. The places where I replace the UChar*/length pair with StringView seem right, but the ones where I replace a String with a StringView aren't sitting well. Anders, do you have any thoughts on this? |