Bug 127214

Summary: [EFL][WK1] Remove and refactor the APIs which use single and base keyword
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 125961    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2014-01-17 21:41:21 PST
Since removed ewk_view_tiled, single is unnecessary keyword
Attachments
Patch (9.71 KB, patch)
2014-01-17 21:43 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (9.75 KB, patch)
2014-01-17 22:11 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-01-17 21:43:58 PST
Created attachment 221533 [details] Patch
Jinwoo Song
Comment 2 2014-01-17 22:06:43 PST
Comment on attachment 221533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221533&action=review > Source/WebKit/efl/ewk/ewk_view.h:2634 > + * @note this is not for general use. We may remove this line entirely.
Ryuan Choi
Comment 3 2014-01-17 22:11:32 PST
Created attachment 221535 [details] Patch
Ryuan Choi
Comment 4 2014-01-17 22:12:09 PST
(In reply to comment #2) > (From update of attachment 221533 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221533&action=review > > > Source/WebKit/efl/ewk/ewk_view.h:2634 > > + * @note this is not for general use. > > We may remove this line entirely. right, fixed.
Gyuyoung Kim
Comment 5 2014-01-19 20:54:51 PST
Comment on attachment 221535 [details] Patch r=me.
WebKit Commit Bot
Comment 6 2014-01-19 22:40:39 PST
Comment on attachment 221535 [details] Patch Clearing flags on attachment: 221535 Committed r162303: <http://trac.webkit.org/changeset/162303>
WebKit Commit Bot
Comment 7 2014-01-19 22:40:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.