Bug 127214 - [EFL][WK1] Remove and refactor the APIs which use single and base keyword
Summary: [EFL][WK1] Remove and refactor the APIs which use single and base keyword
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on: 125961
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-17 21:41 PST by Ryuan Choi
Modified: 2014-01-19 22:40 PST (History)
6 users (show)

See Also:

Attachments
Patch (9.71 KB, patch)
2014-01-17 21:43 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (9.75 KB, patch)
2014-01-17 22:11 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-01-17 21:41:21 PST 
Since removed ewk_view_tiled, single is unnecessary keyword
Comment 1 Ryuan Choi 2014-01-17 21:43:58 PST 
Created attachment 221533 [details]
Patch
Comment 2 Jinwoo Song 2014-01-17 22:06:43 PST 
Comment on attachment 221533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221533&action=review

> Source/WebKit/efl/ewk/ewk_view.h:2634
> + * @note this is not for general use.

We may remove this line entirely.
Comment 3 Ryuan Choi 2014-01-17 22:11:32 PST 
Created attachment 221535 [details]
Patch
Comment 4 Ryuan Choi 2014-01-17 22:12:09 PST 
(In reply to comment #2)
> (From update of attachment 221533 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221533&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.h:2634
> > + * @note this is not for general use.
> 
> We may remove this line entirely.

right, fixed.
Comment 5 Gyuyoung Kim 2014-01-19 20:54:51 PST 
Comment on attachment 221535 [details]
Patch

r=me.
Comment 6 WebKit Commit Bot 2014-01-19 22:40:39 PST 
Comment on attachment 221535 [details]
Patch

Clearing flags on attachment: 221535

Committed r162303: <http://trac.webkit.org/changeset/162303>
Comment 7 WebKit Commit Bot 2014-01-19 22:40:42 PST 
All reviewed patches have been landed.  Closing bug.