Bug 127211

Summary: Use unsigned type for the size of CSSParserValueList
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebCore Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2014-01-17 20:42:48 PST
The type of CSSParserValueList's size is unsigned.
Attachments
Patch (1.24 KB, patch)
2014-01-17 21:05 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (1.54 KB, patch)
2014-01-19 22:39 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-01-17 21:05:13 PST
Created attachment 221529 [details] Patch
Andreas Kling
Comment 2 2014-01-18 15:38:13 PST
Comment on attachment 221529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221529&action=review > Source/WebCore/css/CSSParser.cpp:1798 > - int num = inShorthand() ? 1 : m_valueList->size(); > + unsigned num = inShorthand() ? 1 : m_valueList->size(); There's identical code on line 3499. Please make the same change there.
Jinwoo Song
Comment 3 2014-01-19 22:39:44 PST
Created attachment 221615 [details] Patch Applied Kling's comment.
WebKit Commit Bot
Comment 4 2014-01-19 23:20:59 PST
Comment on attachment 221615 [details] Patch Clearing flags on attachment: 221615 Committed r162305: <http://trac.webkit.org/changeset/162305>
WebKit Commit Bot
Comment 5 2014-01-19 23:21:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.