Bug 127206

Summary: Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, joepeck, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
[PATCH] Proposed Fix andersca: review+

Description Joseph Pecoraro 2014-01-17 17:05:17 PST
Add missing overrides to WebCore/inspector with clang-modernize:

    shell> clang-modernize -add-override -p compile_commands.json -include ./inspector -summary
    Parse: /Users/pecoraro/Code/webkit/Source/WebCore/inspector
    Transform: AddOverride - Accepted: 1488
Comment 1 Joseph Pecoraro 2014-01-17 17:07:05 PST
Created attachment 221514 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-01-17 17:08:25 PST
Attachment 221514 [details] did not pass style-queue:

ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:77:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:276:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:116:  The parameter name "pseudoIdMatches" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:107:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 37 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2014-01-20 13:50:02 PST
Committed <http://trac.webkit.org/changeset/162369>.