| Summary: | Silence a warning emitted when preprocessing mediaControlsApple.js | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, jer.noble | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andy Estes
2014-01-17 16:25:30 PST
Created attachment 221509 [details]
Silence a warning emitted when preprocessing mediaControlsApple.js
Comment on attachment 221509 [details] Silence a warning emitted when preprocessing mediaControlsApple.js View in context: https://bugs.webkit.org/attachment.cgi?id=221509&action=review r=me, although my suggestion would be slightly cleaner if it works because we can still use the JS file as-is during development. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:839 > return (time < 0 ? '-' : '' ) + String('00' + intMinutes).slice(-2) + ":" + String('00' + intSeconds).slice(-2) I think you can also silence this warning by replacing the empty single-quotes with double-quotes: '' -> "" Created attachment 221511 [details]
Work around a preprocessor warning in mediaControlsApple.js
Comment on attachment 221511 [details] Work around a preprocessor warning in mediaControlsApple.js Clearing flags on attachment: 221511 Committed r162233: <http://trac.webkit.org/changeset/162233> All reviewed patches have been landed. Closing bug. |