Bug 127204

Summary: Silence a warning emitted when preprocessing mediaControlsApple.js
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Silence a warning emitted when preprocessing mediaControlsApple.js
none
Work around a preprocessor warning in mediaControlsApple.js none

Andy Estes
Reported 2014-01-17 16:25:30 PST
Silence a warning emitted when preprocessing mediaControlsApple.js
Attachments
Silence a warning emitted when preprocessing mediaControlsApple.js (1.51 KB, patch)
2014-01-17 16:26 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Work around a preprocessor warning in mediaControlsApple.js (1.51 KB, patch)
2014-01-17 16:43 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-01-17 16:26:42 PST
Created attachment 221509 [details] Silence a warning emitted when preprocessing mediaControlsApple.js
Eric Carlson
Comment 2 2014-01-17 16:41:13 PST
Comment on attachment 221509 [details] Silence a warning emitted when preprocessing mediaControlsApple.js View in context: https://bugs.webkit.org/attachment.cgi?id=221509&action=review r=me, although my suggestion would be slightly cleaner if it works because we can still use the JS file as-is during development. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:839 > return (time < 0 ? '-' : '' ) + String('00' + intMinutes).slice(-2) + ":" + String('00' + intSeconds).slice(-2) I think you can also silence this warning by replacing the empty single-quotes with double-quotes: '' -> ""
Andy Estes
Comment 3 2014-01-17 16:43:12 PST
Created attachment 221511 [details] Work around a preprocessor warning in mediaControlsApple.js
WebKit Commit Bot
Comment 4 2014-01-17 17:13:49 PST
Comment on attachment 221511 [details] Work around a preprocessor warning in mediaControlsApple.js Clearing flags on attachment: 221511 Committed r162233: <http://trac.webkit.org/changeset/162233>
WebKit Commit Bot
Comment 5 2014-01-17 17:13:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.