Bug 127202

Summary: Clean up PageCache classes
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Anders Carlsson 2014-01-17 16:00:45 PST 
Clean up PageCache classes
Comment 1 Anders Carlsson 2014-01-17 16:01:53 PST 
Created attachment 221503 [details]
Patch
Comment 2 Anders Carlsson 2014-01-17 16:06:09 PST 
Created attachment 221506 [details]
Patch
Comment 3 Andreas Kling 2014-01-17 16:16:46 PST 
Comment on attachment 221506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221506&action=review

k

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1414
> -    OwnPtr<WebCachedFramePlatformData> webPlatformData = adoptPtr(new WebCachedFramePlatformData([m_webFrame->_private->webFrameView documentView]));
> -    cachedFrame->setCachedFramePlatformData(webPlatformData.release());
> +    auto webPlatformData = std::make_unique<WebCachedFramePlatformData>(m_webFrame->_private->webFrameView.documentView);
> +    cachedFrame->setCachedFramePlatformData(std::move(webPlatformData));

I'd get rid of the temporary here, since using it after this point would be an error anyway.
Comment 4 Anders Carlsson 2014-01-17 17:43:02 PST 
Committed r162234: <http://trac.webkit.org/changeset/162234>