Bug 127148

Summary: glReadPixels should use UNSIGNED_BYTE on iOS
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, kondapallykalyan, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Dean Jackson
Reported 2014-01-16 15:00:20 PST
Our glReadPixels call (for canvas readback) uses GL_UNSIGNED_INT_8_8_8_8_REV. On iOS this is #defined to GL_RGBA, which is very wrong. We should use GL_UNSIGNED_BYTE.
Attachments
Patch (1.49 KB, patch)
2014-01-16 15:02 PST, Dean Jackson 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-01-16 15:02:51 PST
Created attachment 221418 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-01-16 15:06:45 PST
<rdar://problem/15839956>
Dean Jackson
Comment 3 2014-01-16 15:23:16 PST
Committed r162160: <http://trac.webkit.org/changeset/162160>
Note You need to log in before you can comment on or make changes to this bug.