127148 – glReadPixels should use UNSIGNED_BYTE on iOS

RESOLVED FIXED127148

glReadPixels should use UNSIGNED_BYTE on iOS

https://bugs.webkit.org/show_bug.cgi?id=127148

Summary glReadPixels should use UNSIGNED_BYTE on iOS

Dean Jackson

Reported 2014-01-16 15:00:20 PST

Our glReadPixels call (for canvas readback) uses GL_UNSIGNED_INT_8_8_8_8_REV. On iOS this is #defined to GL_RGBA, which is very wrong. We should use GL_UNSIGNED_BYTE.

Attachments
Patch (1.49 KB, patch) 2014-01-16 15:02 PST, Dean Jackson	benjamin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2014-01-16 15:02:51 PST

Created attachment 221418 [details] Patch

Radar WebKit Bug Importer

Comment 2 2014-01-16 15:06:45 PST

<rdar://problem/15839956>

Dean Jackson

Comment 3 2014-01-16 15:23:16 PST

Committed r162160: <http://trac.webkit.org/changeset/162160>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebGL

Assignee

Dean Jackson

Reported

2014-01-16 15:00 PST

Modified

2014-01-16 15:23 PST History

CC List

5 users Show

URL

Keywords InRadar

Depends on

Blocks