Bug 127148 - glReadPixels should use UNSIGNED_BYTE on iOS
Summary: glReadPixels should use UNSIGNED_BYTE on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-16 15:00 PST by Dean Jackson
Modified: 2014-01-16 15:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2014-01-16 15:02 PST, Dean Jackson 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-01-16 15:00:20 PST 
Our glReadPixels call (for canvas readback) uses GL_UNSIGNED_INT_8_8_8_8_REV. On iOS this is #defined to GL_RGBA, which is very wrong. We should use GL_UNSIGNED_BYTE.
Comment 1 Dean Jackson 2014-01-16 15:02:51 PST 
Created attachment 221418 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-01-16 15:06:45 PST 
<rdar://problem/15839956>
Comment 3 Dean Jackson 2014-01-16 15:23:16 PST 
Committed r162160: <http://trac.webkit.org/changeset/162160>