Bug 127135

Summary: GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review-

Myles C. Maxfield
Reported 2014-01-16 12:39:17 PST
GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily
Attachments
Patch (3.70 KB, patch)
2014-01-28 13:03 PST, Myles C. Maxfield 		simon.fraser: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-01-28 13:03:47 PST
Created attachment 222475 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-01-28 14:58:02 PST
Comment on attachment 222475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222475&action=review > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1461 > + if (m_state.shouldUseContextColors) > +#endif I hate #ifdeffed control flow. > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1474 > + if (fillColorIsNotEqualToStrokeColor) > + setCGFillColor(platformContext(), fillColor(), fillColorSpace()); This indentation looks wrong.
Myles C. Maxfield
Comment 3 2014-02-11 17:54:14 PST
Fixed in http://trac.webkit.org/changeset/163921
Note You need to log in before you can comment on or make changes to this bug.