Bug 127135

Summary:

GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Layout and Rendering

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, jonlee, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review-

Description Myles C. Maxfield 2014-01-16 12:39:17 PST

GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily

Comment 1 Myles C. Maxfield 2014-01-28 13:03:47 PST

Created attachment 222475 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-01-28 14:58:02 PST

Comment on attachment 222475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222475&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1461
> +    if (m_state.shouldUseContextColors)
> +#endif

I hate #ifdeffed control flow.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1474
> +        if (fillColorIsNotEqualToStrokeColor)
> +            setCGFillColor(platformContext(), fillColor(), fillColorSpace());

This indentation looks wrong.

Comment 3 Myles C. Maxfield 2014-02-11 17:54:14 PST

Fixed in http://trac.webkit.org/changeset/163921