Bug 127129

Summary: ArithSin in FTL
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch fpizlo: review+, commit-queue: commit-queue-

Matthew Mirman
Reported 2014-01-16 12:12:21 PST
patch forthcoming
Attachments
Patch (4.51 KB, patch)
2014-01-16 12:28 PST, Matthew Mirman 		fpizlo: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Mirman
Comment 1 2014-01-16 12:28:17 PST
Created attachment 221401 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-16 12:32:08 PST
Comment on attachment 221401 [details] Patch Rejecting attachment 221401 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 221401, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ToLLVM.cpp Hunk #1 succeeded at 286 (offset -31 lines). Hunk #2 succeeded at 1117 (offset -56 lines). Hunk #3 FAILED at 4310. 1 out of 3 hunks FAILED -- saving rejects to file Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp.rej patching file Source/JavaScriptCore/ftl/FTLOutput.h patching file Source/JavaScriptCore/tests/stress/ftl-arithsin.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5417744627400704
Filip Pizlo
Comment 3 2014-01-16 12:34:01 PST
(In reply to comment #2) > (From update of attachment 221401 [details]) > Rejecting attachment 221401 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 221401, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > ToLLVM.cpp > Hunk #1 succeeded at 286 (offset -31 lines). > Hunk #2 succeeded at 1117 (offset -56 lines). > Hunk #3 FAILED at 4310. > 1 out of 3 hunks FAILED -- saving rejects to file Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp.rej > patching file Source/JavaScriptCore/ftl/FTLOutput.h > patching file Source/JavaScriptCore/tests/stress/ftl-arithsin.js > > Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit > > Full output: http://webkit-queues.appspot.com/results/5417744627400704 Oops, right - commit-queue doesn't know how to land on branch. I will land this myself.
Filip Pizlo
Comment 4 2014-01-16 12:55:26 PST
Landed in http://trac.webkit.org/changeset/162142
Matthew Mirman
Comment 5 2014-01-20 16:01:05 PST
*** Bug 127319 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.