Bug 127114
| Summary: | check-webkit-style should catch unnecessary explicit constructors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Blaze Burg
If you add 'explicit' to a constructor with >1 non-defaulted parameters, the style checker should complain. There's no point having explicit in that case.
Good:
explicit Foo();
explicit Foo(const String&);
explicit Foo(const String&, bool something = false);
Bad:
explicit Foo(Bar, Baz)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |