Bug 127114

Summary: check-webkit-style should catch unnecessary explicit constructors
Product: WebKit Reporter: BJ Burg <bburg>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Description BJ Burg 2014-01-16 09:23:22 PST
If you add 'explicit' to a constructor with >1 non-defaulted parameters, the style checker should complain. There's no point having explicit in that case.


Good:

explicit Foo();
explicit Foo(const String&);
explicit Foo(const String&, bool something = false);

Bad:

explicit Foo(Bar, Baz)