Bug 127106

Summary: [GStreamer] media/video-canvas-drawing-output.html fails after bumping to 1.2.1
Product: WebKit Reporter: Michal Pakula vel Rutka <mpakulavelrutka>
Component: WebKit EFLAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, calvaris, commit-queue, dino, eric.carlson, jer.noble, lucas.de.marchi, Ms2ger, pnormand, webkit-bug-importer, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michal Pakula vel Rutka
Reported 2014-01-16 06:35:09 PST
Layout test media/video-canvas-drawing-output.html started to fail after bumping GStreamer to 1.2.1 in r160151 <http://trac.webkit.org/changeset/160151> diff: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r162122%20%2812447%29/media/video-canvas-drawing-output-diff.txt
Attachments
Patch (2.21 KB, patch)
2017-08-24 07:51 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2014-03-05 00:51:26 PST
Here's the diff, in case the buildbot link expires. --- /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/media/video-canvas-drawing-output-expected.txt +++ /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/media/video-canvas-drawing-output-actual.txt @@ -1,20 +1,20 @@ EVENT(canplaythrough) EVENT(seeked) -Saw close enough to (194, 193, 14) at (40, 165) OK -Saw close enough to (17, 197, 195) at (56, 165) OK -Saw close enough to (20, 200, 18) at (73, 165) OK +Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL +Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL +Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL EVENT(seeked) -Saw close enough to (194, 193, 14) at (40, 165) OK -Saw close enough to (17, 197, 195) at (56, 165) OK -Saw close enough to (20, 200, 18) at (73, 165) OK +Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL +Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL +Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL EVENT(seeked) -Saw close enough to (194, 193, 14) at (40, 165) OK -Saw close enough to (17, 197, 195) at (56, 165) OK -Saw close enough to (20, 200, 18) at (73, 165) OK +Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL +Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL +Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL EVENT(seeked) -Saw close enough to (194, 193, 14) at (40, 165) OK -Saw close enough to (17, 197, 195) at (56, 165) OK -Saw close enough to (20, 200, 18) at (73, 165) OK +Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL +Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL +Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL END OF TEST
Philippe Normand
Comment 2 2014-03-05 00:52:09 PST
Also skipped in GTK.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3 2017-08-24 07:51:38 PDT
Created attachment 318984 [details] Patch
Xabier Rodríguez Calvar
Comment 4 2017-08-24 08:04:51 PDT
Comment on attachment 318984 [details] Patch I'm ok, but let's wait for Dino's green light as he wrote the test.
WebKit Commit Bot
Comment 5 2017-09-04 12:34:27 PDT
Comment on attachment 318984 [details] Patch Clearing flags on attachment: 318984 Committed r221591: <http://trac.webkit.org/changeset/221591>
WebKit Commit Bot
Comment 6 2017-09-04 12:34:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.