Summary: | [EFL][WK2] EwkView can not be shown without re-sizing once it is hidden. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eunmi Lee <enmi.lee> | ||||||||
Component: | WebKit EFL | Assignee: | Eunmi Lee <enmi.lee> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Eunmi Lee
2014-01-16 00:10:01 PST
Created attachment 221340 [details]
Patch
Comment on attachment 221340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221340&action=review Nice. it was one of known issues, long time. Comment looks little bit confusing to me, but I am not good with english. > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305 > + setNeedsSurfaceResize(); How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer. Comment on attachment 221340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221340&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305 >> + setNeedsSurfaceResize(); > > How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer. Thanks, it's better. I will update patch. Created attachment 221423 [details]
Patch
Comment on attachment 221423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221423&action=review > Source/WebKit2/ChangeLog:10 > + to true for accelerated mode to prevent to show black empty view for It looks this description is a little ambiguous. Created attachment 221427 [details]
Patch
Update Changelog.
Comment on attachment 221427 [details] Patch Clearing flags on attachment: 221427 Committed r162182: <http://trac.webkit.org/changeset/162182> All reviewed patches have been landed. Closing bug. |