Bug 127081

Summary:

AX: WebKit is not firing AXMenuItemSelectedNotification

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, commit-queue, dmazzoni, eflews.bot, gyuyoung.kim, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	mario: review+

Description chris fleizach 2014-01-15 21:02:22 PST

AX: WebKit is not firing AXMenuItemSelectedNotification

AXMenuItemSelectedNotification
https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA-UAIG/1.0/tests/test-files/test94.html


<rdar://problem/15668929>

Comment 1 chris fleizach 2014-01-15 21:06:55 PST

Created attachment 221328 [details]
patch

Comment 2 EFL EWS Bot 2014-01-15 21:19:44 PST

Comment on attachment 221328 [details]
patch

Attachment 221328 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5416725646409728

Comment 3 chris fleizach 2014-01-15 21:28:07 PST

(In reply to comment #2)
> (From update of attachment 221328 [details])
> Attachment 221328 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/5416725646409728

this does not seem to be related, at least looking at the output

Comment 4 Mario Sanchez Prada 2014-01-16 02:27:47 PST

Comment on attachment 221328 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221328&action=review

Lgtm

> Source/WebCore/accessibility/AXObjectCache.cpp:742
> +    if (nodeHasRole(node, "menuitem") || nodeHasRole(node, "menuitemradio") || nodeHasRole(node, "menuitemcheckbox")) {

Nit. I think an early return for this condition would be cleaner. I would also add a null check for node to the OR.

Comment 5 chris fleizach 2014-01-16 08:59:47 PST

http://trac.webkit.org/changeset/162130

Thanks Mario!