| Summary: | Move user agent code to WebCore and unify some code between OS X and iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2014-01-15 20:58:50 PST
Created attachment 221327 [details]
Patch
Comment on attachment 221327 [details] Patch Attachment 221327 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4670254961655808 New failing tests: http/tests/navigation/useragent.php Created attachment 221333 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 221327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221327&action=review r=me! > Source/WebKit/mac/WebView/WebView.mm:678 > - NSString *fullVersion = [[NSBundle bundleForClass:[WebView class]] objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey]; > + NSString *fullVersion = [[NSBundle bundleForClass:NSClassFromString(@"WKView")] objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey]; You should keep this calling [WebView class]. Committed r162114: <http://trac.webkit.org/changeset/162114> Little follow up for iOS: http://trac.webkit.org/changeset/162116 |