Bug 127070

Summary: Add MarkedBlockInlines.h
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: NEW ---    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review-

Description Mark Hahnenberg 2014-01-15 15:27:18 PST 
MarkedBlock.h is getting pretty unwieldy in terms of how many inline functions it has. MarkedBlock.cpp also contains some functions that could benefit from inlining, but which can't reside in MarkedBlock.h. It seems the time has come for MarkedBlockInlines.h.
Comment 1 Mark Hahnenberg 2014-03-26 11:55:53 PDT 
Created attachment 227868 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-26 11:56:47 PDT 
Attachment 227868 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/PropertyTable.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2014-03-26 12:02:38 PDT 
Created attachment 227869 [details]
Patch
Comment 4 WebKit Commit Bot 2014-03-26 12:03:25 PDT 
Attachment 227869 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/PropertyTable.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2014-03-26 20:26:24 PDT 
Comment on attachment 227869 [details]
Patch

rs=me if you fix the build