Bug 127062

Summary: DumpRenderTree doesn't disable web preferences autosave
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2014-01-15 12:56:55 PST
Didn't we all assume that it disabled autosave? I observed that running http/tests/security tests changed the value of -[WebPreferences privateBrowsingEnabled] in parallel DRT processes, which is horrible, because it could then easily get picked up by -[WebView _preferencesChanged:] any time it's called for any reason.
Attachments
proposed fix (1.28 KB, patch)
2014-01-15 12:58 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-01-15 12:58:33 PST
Created attachment 221298 [details] proposed fix
WebKit Commit Bot
Comment 2 2014-01-15 14:39:16 PST
Comment on attachment 221298 [details] proposed fix Clearing flags on attachment: 221298 Committed r162092: <http://trac.webkit.org/changeset/162092>
WebKit Commit Bot
Comment 3 2014-01-15 14:39:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.