Bug 127062

Summary:

DumpRenderTree doesn't disable web preferences autosave

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mitz, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2014-01-15 12:56:55 PST

Didn't we all assume that it disabled autosave?

I observed that running http/tests/security tests changed the value of -[WebPreferences privateBrowsingEnabled] in parallel DRT processes, which is horrible, because it could then easily get picked up by -[WebView _preferencesChanged:] any time it's called for any reason.

Comment 1 Alexey Proskuryakov 2014-01-15 12:58:33 PST

Created attachment 221298 [details]
proposed fix

Comment 2 WebKit Commit Bot 2014-01-15 14:39:16 PST

Comment on attachment 221298 [details]
proposed fix

Clearing flags on attachment: 221298

Committed r162092: <http://trac.webkit.org/changeset/162092>

Comment 3 WebKit Commit Bot 2014-01-15 14:39:17 PST

All reviewed patches have been landed.  Closing bug.