| Summary: | [EFL][WK2] Implement TestController::setHidden | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, gyuyoung.kim, lucas.de.marchi, ryuan.choi | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Michal Pakula vel Rutka
2014-01-15 02:05:21 PST
Created attachment 221251 [details]
proposed patch
Looks good to me. Comment on attachment 221251 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review > Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110 > + if (!view) Is there any possibility that platformView() is null ? Looks unneeded check. Comment on attachment 221251 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review >> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110 >> + if (!view) > > Is there any possibility that platformView() is null ? Looks unneeded check. I find a possibility platformView() can return null. It would be good if you print a log when view is null. Created attachment 221369 [details]
added error log
Comment on attachment 221369 [details] added error log Clearing flags on attachment: 221369 Committed r162123: <http://trac.webkit.org/changeset/162123> All reviewed patches have been landed. Closing bug. |