Bug 127028

Summary:

[iOS] Crash in NavigatorBase::vendor loading apple.com

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, ddkilzer, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-01-14 18:38:13 PST

iOS crash loading apple.com.

-- NavigatorBase.cpp

    String NavigatorBase::vendor() const
    {
        return WEBCORE_NAVIGATOR_VENDOR;
    }

-- config.h

    #if PLATFORM(IOS)
    #define WEBCORE_NAVIGATOR_PLATFORM wkGetPlatformNameForNavigator();
    #define WEBCORE_NAVIGATOR_VENDOR wkGetVendorNameForNavigator();
    #endif

--

Looks like we're missing calls to fill in these WKSI functions.

Comment 1 Joseph Pecoraro 2014-01-14 18:41:40 PST

Created attachment 221224 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2014-01-14 20:22:08 PST

Comment on attachment 221224 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 221224

Committed r162043: <http://trac.webkit.org/changeset/162043>

Comment 3 WebKit Commit Bot 2014-01-14 20:22:10 PST

All reviewed patches have been landed.  Closing bug.