Bug 126999

Summary:

[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Platform

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, joepeck

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	joepeck: review+

Description Daniel Bates 2014-01-14 11:29:47 PST

We should retain the NSMutableDictionary dictionary returned by [NSMutableDictionary dictionary] in WebCore::QLPreviewConverterDictionary() and WebCore::QLContentDictionary().

Comment 1 Daniel Bates 2014-01-14 11:32:05 PST

Created attachment 221185 [details]
Patch

Comment 2 Joseph Pecoraro 2014-01-14 11:34:46 PST

Comment on attachment 221185 [details]
Patch

r=me

How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release?

Comment 3 Daniel Bates 2014-01-14 11:35:54 PST

(In reply to comment #2)
> (From update of attachment 221185 [details])
> r=me
> 
> How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release?

Will change before landing.

Comment 4 Daniel Bates 2014-01-14 12:54:02 PST

<rdar://problem/15810305>

Comment 5 Daniel Bates 2014-01-14 12:55:38 PST

Committed r161997: <http://trac.webkit.org/changeset/161997>