Bug 126983

Summary: Remove extra includes from DFG
Product: WebKit Reporter: Peter Molnar <pmolnar.u-szeged>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, fpizlo, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review-, kling: commit-queue-
updated patch none

Peter Molnar
Reported 2014-01-14 07:00:24 PST
Remove extra includes from DFG
Attachments
patch (46.10 KB, patch)
2014-01-14 07:01 PST, Peter Molnar 		kling: review-
kling: commit-queue-
DetailsFormatted DiffDiff
updated patch (46.37 KB, patch)
2014-02-10 05:49 PST, Peter Molnar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Molnar
Comment 1 2014-01-14 07:01:41 PST
Created attachment 221159 [details] patch
Andreas Kling
Comment 2 2014-02-07 02:11:11 PST
Comment on attachment 221159 [details] patch This doesn't build on windows (see EWS.)
Peter Molnar
Comment 3 2014-02-10 05:48:50 PST
(In reply to comment #2) > (From update of attachment 221159 [details]) > This doesn't build on windows (see EWS.) That EWS error was probably caused by the bot being red at the moment (unable to build with or without the patch...). Anyway, I'm attaching an updated patch.
Peter Molnar
Comment 4 2014-02-10 05:49:15 PST
Created attachment 223702 [details] updated patch
WebKit Commit Bot
Comment 5 2014-02-10 10:15:45 PST
Comment on attachment 223702 [details] updated patch Clearing flags on attachment: 223702 Committed r163796: <http://trac.webkit.org/changeset/163796>
WebKit Commit Bot
Comment 6 2014-02-10 10:15:47 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 7 2014-02-10 11:15:48 PST
I don't like changes like this. Why are you removing #include statements? The change is not justified either in this bug or in the changelog. Its primary effect appears to make the code less robust against change because it only builds due to accidental transitive header dependencies. I'm going to roll this out. If you feel strongly about this change, you should justify why you are doing it.
Filip Pizlo
Comment 8 2014-02-10 11:21:52 PST
Rolled out in http://trac.webkit.org/changeset/163802 If you want to make a change like this, please give a reason for it.
Note You need to log in before you can comment on or make changes to this bug.