| Summary: | Remove extra includes from DFG | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Molnar <pmolnar.u-szeged> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, kling, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Molnar
2014-01-14 07:00:24 PST
Created attachment 221159 [details]
patch
Comment on attachment 221159 [details]
patch
This doesn't build on windows (see EWS.)
(In reply to comment #2) > (From update of attachment 221159 [details]) > This doesn't build on windows (see EWS.) That EWS error was probably caused by the bot being red at the moment (unable to build with or without the patch...). Anyway, I'm attaching an updated patch. Created attachment 223702 [details]
updated patch
Comment on attachment 223702 [details] updated patch Clearing flags on attachment: 223702 Committed r163796: <http://trac.webkit.org/changeset/163796> All reviewed patches have been landed. Closing bug. I don't like changes like this. Why are you removing #include statements? The change is not justified either in this bug or in the changelog. Its primary effect appears to make the code less robust against change because it only builds due to accidental transitive header dependencies. I'm going to roll this out. If you feel strongly about this change, you should justify why you are doing it. Rolled out in http://trac.webkit.org/changeset/163802 If you want to make a change like this, please give a reason for it. |