Bug 126959

Summary: CStack: Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES)
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. msaboff: review+

Mark Lam
Reported 2014-01-13 21:04:18 PST
The !ENABLE(COMPUTED_GOTO_OPCODES) build of the C loop LLINT reveals the unused piece of LLINT code for sanitizeStackForVM() was still being built in. In the computed got case, the sanitizeStackForVM() code only results in some unused code in CLoop::execute() and an extra local label which is harmless. In the non-computed goto case, it results in a case statement for an unknown opcode named "sanitizeStackForVM". This results in a build failure. The fix is simply to exclude the unused LLINT sanitizeStackForVM() from the C loop build. Patch coming.
Attachments
the patch. (1.44 KB, patch)
2014-01-13 21:15 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-01-13 21:15:44 PST
Created attachment 221102 [details] the patch.
Mark Lam
Comment 2 2014-01-14 09:12:44 PST
Thanks for the review. Landed in r161975 on the jsCStack branch: <http://trac.webkit.org/r161975>.
Note You need to log in before you can comment on or make changes to this bug.