| Summary: | [iOS] Exclude Shims and PluginProcess.app from the WebKit2 build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, dbates, ddkilzer, mitz, mrowe, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andy Estes
2014-01-13 15:17:05 PST
Created attachment 221083 [details]
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build
Comment on attachment 221083 [details] [iOS] Exclude shims and PluginProcess.app from the WebKit2 build View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review Looks sane to me. Feel free to ask a build system expert for a more thorough review. > Source/WebKit2/Configurations/Shim.xcconfig:33 > +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon -framework QuartzCore; > +OTHER_LDFLAGS_SecItemShim = -framework Security; > +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security; I take it you feel that it wouldn't improve readability to include _macosx_ in the names of these variables. Committed r161918: <http://trac.webkit.org/changeset/161918> (In reply to comment #2) > (From update of attachment 221083 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review > > Looks sane to me. Feel free to ask a build system expert for a more thorough review. > > > Source/WebKit2/Configurations/Shim.xcconfig:33 > > +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon -framework QuartzCore; > > +OTHER_LDFLAGS_SecItemShim = -framework Security; > > +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security; > > I take it you feel that it wouldn't improve readability to include _macosx_ in the names of these variables. Per a recommendation from mitzpettel, I ended up creating new .xcconfigs for each of the shims and moving these options there. |